Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the upload of custom artifacts from artifacts-to-be-uploaded folder #5092

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Apr 12, 2024

This is to support a new use case where I need to upload different Android and iOS apps instead of the regular wheel files as the artifacts of Nova Linux job. It looks like the easiest way is to have a folder artifacts-to-be-uploaded in the current workspace, and let the job script moves any artifacts it needs to persist there.

@huydhn huydhn requested review from seemethere and ZainRizvi April 12, 2024 01:54
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2024
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 5:46pm

@huydhn huydhn requested a review from a team April 12, 2024 17:39
@huydhn
Copy link
Contributor Author

huydhn commented Apr 12, 2024

Going to go ahead and merge the change now, waiting for window ephemeral runner is taking too long :)

@huydhn huydhn merged commit 82b46a0 into main Apr 12, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants