-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker release matrix workflow #5065
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
name: Generates the docker release matrix | ||
|
||
on: | ||
workflow_call: | ||
inputs: | ||
channel: | ||
description: "Channel to use (nightly, test, release, all)" | ||
default: "" | ||
type: string | ||
test-infra-repository: | ||
description: "Test infra repository to use" | ||
default: "pytorch/test-infra" | ||
type: string | ||
test-infra-ref: | ||
description: "Test infra reference to use" | ||
default: "main" | ||
type: string | ||
outputs: | ||
matrix: | ||
description: "Generated build matrix" | ||
value: ${{ jobs.generate.outputs.matrix }} | ||
|
||
jobs: | ||
generate: | ||
outputs: | ||
matrix: ${{ steps.generate.outputs.matrix }} | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: '3.10' | ||
- name: Checkout test-infra repository | ||
uses: actions/checkout@v3 | ||
with: | ||
repository: ${{ inputs.test-infra-repository }} | ||
ref: ${{ inputs.test-infra-ref }} | ||
- uses: ./.github/actions/set-channel | ||
- name: Generate docker release matrix | ||
id: generate | ||
env: | ||
CHANNEL: ${{ inputs.channel != '' && inputs.channel || env.CHANNEL }} | ||
run: | | ||
set -eou pipefail | ||
MATRIX_BLOB="$(python3 tools/scripts/generate_docker_release_matrix.py)" | ||
echo "${MATRIX_BLOB}" | ||
echo "matrix=${MATRIX_BLOB}" >> "${GITHUB_OUTPUT}" | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ inputs.test-infra-repository }}-${{ inputs.test-infra-ref }} | ||
cancel-in-progress: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
#!/usr/bin/env python3 | ||
|
||
"""Generates a matrix for docker releases through github actions | ||
|
||
Will output a condensed version of the matrix. Will include fllowing: | ||
* CUDA version short | ||
* CUDA full version | ||
* CUDNN version short | ||
* Image type either runtime or devel | ||
* Platform linux/arm64,linux/amd64 | ||
|
||
""" | ||
|
||
import json | ||
import os | ||
import sys | ||
import argparse | ||
from typing import Dict, List | ||
|
||
import generate_binary_build_matrix | ||
|
||
DOCKER_IMAGE_TYPES = ["runtime", "devel"] | ||
|
||
|
||
def generate_docker_matrix(channel: str) -> Dict[str, List[Dict[str, str]]]: | ||
|
||
ret: List[Dict[str, str]] = [] | ||
for cuda in generate_binary_build_matrix.CUDA_ARCHES_DICT[channel]: | ||
version = generate_binary_build_matrix.CUDA_CUDDN_VERSIONS[cuda] | ||
for image in DOCKER_IMAGE_TYPES: | ||
ret.append( | ||
{ | ||
"cuda": cuda, | ||
"cuda_full_version": version["cuda"], | ||
"cudnn_version": version["cudnn"], | ||
"image_type": image, | ||
"platform": "linux/arm64,linux/amd64", | ||
} | ||
) | ||
return {"include": ret} | ||
|
||
|
||
def main(args) -> None: | ||
parser = argparse.ArgumentParser() | ||
parser.add_argument( | ||
"--channel", | ||
help="Channel to use, default nightly", | ||
type=str, | ||
choices=["nightly", "test", "release", "all"], | ||
default=os.getenv("CHANNEL", "nightly"), | ||
) | ||
options = parser.parse_args(args) | ||
|
||
build_matrix = generate_docker_matrix(options.channel) | ||
print(json.dumps(build_matrix)) | ||
|
||
if __name__ == "__main__": | ||
main(sys.argv[1:]) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks weird, I don't think you need to pass
sys.argv
toargparse
like this, just callingoptions = parser.parse_args()
without any arguments works.