Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaks from googletest upgrade (vulkan_compute_api_test) (#9760) #9868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix breaks from googletest upgrade (vulkan_compute_api_test) (#9760) #9868

wants to merge 1 commit into from

Conversation

hershi
Copy link

@hershi hershi commented Apr 3, 2025 •
edited by pytorch-bot bot
Loading

Summary:

Missing include in vulkan_compute_api_test.cpp - added

Reviewed By: SS-JIA

Differential Revision: D72139603

cc @SS-JIA @manuelcandales @cbilgin

@facebook-github-bot
Fix breaks from googletest upgrade (vulkan_compute_api_test) (pytorch…
d5605bf 
…#9760)

Summary:

Missing include in vulkan_compute_api_test.cpp - added

Reviewed By: SS-JIA

Differential Revision: D72139603
@hershi hershi force-pushed the export-D72139603 branch from a10301c to d5605bf Compare April 3, 2025 08:23
@hershi hershi requested a review from SS-JIA as a code owner April 3, 2025 08:23
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Apr 3, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9868

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d5605bf with merge base 3600d4f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72139603

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@hershi hershi mentioned this pull request Apr 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SS-JIA SS-JIA Awaiting requested review from SS-JIA SS-JIA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hershi @facebook-github-bot