Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaks from googletest upgrade #9760

Closed
wants to merge 1 commit into from

Conversation

hershi
Copy link

@hershi hershi commented Mar 30, 2025

Summary: Add missing include for standard C++ library

Reviewed By: 8Keep

@hershi hershi requested a review from SS-JIA as a code owner March 30, 2025 18:04
Copy link

pytorch-bot bot commented Mar 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9760

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 307e837 with merge base 2aa7748 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Mar 30, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72134172

hershi pushed a commit to hershi/executorch that referenced this pull request Mar 30, 2025
Summary:

Add missing include for standard C++ library

Reviewed By: 8Keep

Differential Revision: D72134172
@hershi hershi force-pushed the export-D72134172 branch from 42a0110 to 853b10d Compare March 30, 2025 18:26
@hershi
Copy link
Author

hershi commented Mar 30, 2025

@pytorchbot label "topic: not user facing"

@hershi hershi changed the title Fix breaks from googletest upgrade (D71897516) Fix breaks from googletest upgrade Mar 30, 2025
Summary:
Pull Request resolved: pytorch#9760

Add missing include for standard C++ library

Reviewed By: 8Keep

Differential Revision: D72134172
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D72134172

@hershi hershi force-pushed the export-D72134172 branch from 853b10d to 307e837 Compare March 30, 2025 18:33
hershi pushed a commit to hershi/executorch that referenced this pull request Apr 3, 2025
…#9760)

Summary:
Missing include in vulkan_compute_api_test.cpp - added

Reviewed By: SS-JIA

Differential Revision: D72139603
hershi pushed a commit to hershi/executorch that referenced this pull request Apr 3, 2025
…#9760)

Summary:

Missing include in vulkan_compute_api_test.cpp - added

Reviewed By: SS-JIA

Differential Revision: D72139603
@hershi hershi closed this Apr 3, 2025
@hershi
Copy link
Author

hershi commented Apr 3, 2025

Had to recreate as #9868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants