-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build_optimized_size_test.sh #9840
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9840
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 153735d with merge base 1572381 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -0,0 +1,57 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we trigger this? Add it to CI? Also is it possible to re-use https://github.com/pytorch/executorch/blob/main/test/build_size_test.sh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we trigger this? Add it to CI?
As the description says, it is meant for development use.
is it possible to re-use
No, that script wants to disable exceptions, which is appropriate in the embedded systems context but not the "everything else" context. Optimized kernels are not for the embedded systems context AIUI.
Adding a developer-facing size test script for a non-embedded-centric use case (optimized ops, exceptions on, etc.).