[ET-VK] Using shared memory to save position in conv2d dw output op. #7923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7923
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8ffe881 with merge base 7bc06d1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jan 24, 2025
|
This pull request was exported from Phabricator. Differential Revision: D68400890 |
trivedivivek
added a commit
that referenced
this pull request
Jan 24, 2025
This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) ghstack-source-id: 262823001 Pull Request resolved: #7923
This was referenced Jan 24, 2025
…output op." This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400890 |
…output op." This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400890 |
jorgep31415
approved these changes
Jan 24, 2025
…output op." This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400890 |
…output op." This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400890 |
…output op." This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400890 |
…output op." This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400890 |
…output op." This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D68400890 |
facebook-github-bot
merged commit 53d1b0d
into
gh/trivedivivek/51/base
47 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
Jan 29, 2025
…8007) Pull Request resolved: #7923 This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. ghstack-source-id: 263440666 @exported-using-ghexport Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) Co-authored-by: Vivek Trivedi <[email protected]>
trivedivivek
added a commit
that referenced
this pull request
Jan 29, 2025
* [ET-VK] Using shared memory to save position in conv2d dw output op. Pull Request resolved: #7923 This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance. ghstack-source-id: 263440666 @exported-using-ghexport Differential Revision: [D68400890](https://our.internmc.facebook.com/intern/diff/D68400890/) * [ET-VK] Using push constants for conv2d dw. Pull Request resolved: #7928 This diff is related to the use of push constants for convolutional dw (depthwise) in Executorch's Vulkan backend. This optimization improves memory usage. ghstack-source-id: 263440665 @exported-using-ghexport Differential Revision: [D68493849](https://our.internmc.facebook.com/intern/diff/D68493849/) * [ET-VK] Using TmpTensor for width packed versions of q_linear op shader to reduce memory usage. (#8009) Pull Request resolved: #7929 This diff introduces the use of temporary tensors to reduce memory usage in the width packed versions of the q_linear op shader. ghstack-source-id: 263456691 @exported-using-ghexport Differential Revision: [D68561647](https://our.internmc.facebook.com/intern/diff/D68561647/) Co-authored-by: Vivek Trivedi <[email protected]> --------- Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff introduces a change to conv2d dw op to save output positions in shared memory, which reduces register usage and improves performance.
Differential Revision: D68400890