Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ET-VK] Minor improvement to q_linear op shader. #7728

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jan 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7728

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 3 Pending, 1 Unrelated Failure

As of commit c72ff0f with merge base f73b8cf (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68113154

trivedivivek added a commit that referenced this pull request Jan 17, 2025
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

ghstack-source-id: 261906021
Pull Request resolved: #7728
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68113154

trivedivivek added a commit that referenced this pull request Jan 21, 2025
Pull Request resolved: #7728

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
ghstack-source-id: 262384610
This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68113154

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request Jan 22, 2025
Pull Request resolved: #7728

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.
ghstack-source-id: 262478289

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68113154

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request Jan 22, 2025
Pull Request resolved: #7728

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.
ghstack-source-id: 262587309

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68113154

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request Jan 23, 2025
Pull Request resolved: #7728

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.
ghstack-source-id: 262619533

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68113154

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68113154

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

[ghstack-poisoned]
trivedivivek added a commit that referenced this pull request Jan 24, 2025
Pull Request resolved: #7728

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.
ghstack-source-id: 262853434

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68113154

@facebook-github-bot facebook-github-bot merged commit 121b0b3 into gh/trivedivivek/45/base Jan 24, 2025
46 of 47 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/trivedivivek/45/head branch January 24, 2025 07:10
trivedivivek added a commit that referenced this pull request Jan 24, 2025
Pull Request resolved: #7728

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.
ghstack-source-id: 262853434

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

Co-authored-by: Vivek Trivedi <[email protected]>
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Pull Request resolved: #7728

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.
ghstack-source-id: 262853434

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

Co-authored-by: Vivek Trivedi <[email protected]>
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Pull Request resolved: pytorch#7728

This diff contains a minor improvement to the q_linear op shader in the Vulkan backend for Executorch. The code changes in the q_8w_linear.glsl file include a change in position parameter from a 3-element u16vec3 to a 2-element u16vec2.
ghstack-source-id: 262853434

Differential Revision: [D68113154](https://our.internmc.facebook.com/intern/diff/D68113154/)

Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants