Adopt runtime::FunctionRef in thread_parallel_interface.h and thread_parallel.h #10442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10442
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit 5bc4b0c with merge base 6feb623 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Apr 24, 2025
…parallel.h This saves a *ton* of size by no longer requiring callers to create std::function. Test Plan: bash test/build_optimized_size_test.sh && size test/size_test_all_optimized_ops before: ``` ExecuTorch with no ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 153928 Apr 24 13:11 cmake-out/test/size_test ExecuTorch with portable ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 2150960 Apr 24 13:11 cmake-out/test/size_test_all_ops ExecuTorch with optimized ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 11182136 Apr 24 13:11 cmake-out/test/size_test_all_optimized_ops __TEXT __DATA __OBJC others dec hex 5341184 98304 0 4300800000 4306239488 100ac0000 ``` after: ``` ExecuTorch with no ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 153928 Apr 24 13:07 cmake-out/test/size_test ExecuTorch with portable ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 2150960 Apr 24 13:07 cmake-out/test/size_test_all_ops ExecuTorch with optimized ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 5927336 Apr 24 13:07 cmake-out/test/size_test_all_optimized_ops __TEXT __DATA __OBJC others dec hex 4505600 98304 0 4296376320 4300980224 1005bc000 ```` `__TEXT` size improvement is 835584 bytes, or 15%. ghstack-source-id: 2482ad7 ghstack-comment-id: 2828755250 Pull-Request-resolved: #10442
This was referenced Apr 24, 2025
facebook-github-bot
added
the
CLA Signed
digantdesai
approved these changes
Apr 24, 2025
swolchok
added a commit
that referenced
this pull request
Apr 25, 2025
…parallel.h This saves a *ton* of size by no longer requiring callers to create std::function. Test Plan: bash test/build_optimized_size_test.sh && size test/size_test_all_optimized_ops before: ``` ExecuTorch with no ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 153928 Apr 24 13:11 cmake-out/test/size_test ExecuTorch with portable ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 2150960 Apr 24 13:11 cmake-out/test/size_test_all_ops ExecuTorch with optimized ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 11182136 Apr 24 13:11 cmake-out/test/size_test_all_optimized_ops __TEXT __DATA __OBJC others dec hex 5341184 98304 0 4300800000 4306239488 100ac0000 ``` after: ``` ExecuTorch with no ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 153928 Apr 24 13:07 cmake-out/test/size_test ExecuTorch with portable ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 2150960 Apr 24 13:07 cmake-out/test/size_test_all_ops ExecuTorch with optimized ops binary size, unstripped: -rwxr-xr-x 1 swolchok staff 5927336 Apr 24 13:07 cmake-out/test/size_test_all_optimized_ops __TEXT __DATA __OBJC others dec hex 4505600 98304 0 4296376320 4300980224 1005bc000 ```` `__TEXT` size improvement is 835584 bytes, or 15%. ghstack-source-id: 516b5a7 ghstack-comment-id: 2828755250 Pull-Request-resolved: #10442
@digantdesai I was working on reapplying #9842 and #9841 (reverted due to size regression) and iteratively using bloaty on the result of bash test/build_optimized_size_test.sh. There was a clear huge size increase from std::function, and after struggling with how to avoid it, I found my way to function_ref. |
|
Unit tests look good despite two apparent flakes. will merge after rebase. |
This was referenced Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves a ton of size by no longer requiring callers to create std::function.
Test Plan: bash test/build_optimized_size_test.sh && size test/size_test_all_optimized_ops
before:
after:
__TEXTsize improvement is 835584 bytes, or 15%.