-
Notifications
You must be signed in to change notification settings - Fork 531
Re-sync extension/pytree/function_ref.h with LLVM #10440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10440
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 773b183 with merge base 1432243 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
EXPECT_EQ(item1.get(), 1); | ||
val = 0; | ||
FunctionRef<void(int32_t&)> ref2(one); | ||
ref(val); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ref/ref2 perhaps?
bypassing two apparent tests flakes and merging. |
We had an old version, and that version didn't work quite right when
handed a const ref to a callable. Just resync and note divergences
from the original in the comment. Our old version also had an
explicit
constructor, which is not desirable because itcomplicates callsites. It was also a divergence from both LLVM and
the upcoming C++26
std::function_ref.
The test made invalid use of a FunctionRef -- you can't keep one
around past the lifetime of the function object it refers to, but the
test held onto a temporary capturing lambda in an object. I fixed the
test.