Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove discontinued GoogleOpenId backend #515

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Oct 24, 2020

Proposed changes

The Google OpenID backend was discontinued on the server side in 2015, in favor of OpenID Connect (our GoogleOpenIdConnect backend).

https://support.google.com/accounts/answer/6206245

Fixes #462. Fixes #472.

This is needed to get Travis passing again.

Types of changes

Please check the type of change your PR introduces:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

It was discontinued on the server side in 2015, in favor of OpenID
Connect (our GoogleOpenIdConnect backend).

https://support.google.com/accounts/answer/6206245

Fixes python-social-auth#462. Fixes python-social-auth#472.

Signed-off-by: Anders Kaseorg <[email protected]>
Copy link
Member

@nijel nijel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It certainly makes sense to drop this.

@yuekui
Copy link
Contributor

yuekui commented Dec 21, 2020

It certainly makes sense to drop this.

Hi @nijel could you please help to merge this PR and also help to merge others as well? Thanks a lot! (some of the pending PRs were marked as stale and going to be closed without further action taken)

@nijel
Copy link
Member

nijel commented Dec 22, 2020

Sorry, I can't as I don't have write access to this repository. See #445

@andersk andersk mentioned this pull request Jan 9, 2021
9 tasks
@omab omab merged commit 8a29021 into python-social-auth:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants