Pass correct algorithms argument to jwt.decode #514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Several backends passed an incorrect and/or unverified
algorithms
argument to jwt.decode. Theapple
backend passed an unusedalgorithm
argument instead. Theazuread_b2c
,azuread_tenant
, andopen_id_connect
backends passed a value from the untrusted JWT header, potentially opening up a vulnerability to symmetric/asymmetric confusion attacks. Additionally, theazuread_b2c
andazuread_tenant
backends incorrectly passed it as a string rather than a list.Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Other information
Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.