Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kissat support #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tye-singwa
Copy link

Hi, this is attempt to add kissat support to pysat
Cannot add some features:

  • no incremental support
  • no assumptions
  • no propagation
    Checked on linux + windows

@alexeyignatiev
Copy link
Collaborator

Thanks, @tye-singwa. Looks like it does not pass the CI build tests.

@user202729
Copy link

Has been a long time, but this PR causes a segmentation fault for me.

The segmentation fault is in factor.cc

      const unsigned q = quotient_watch.binary.lit;
      watches *q_watches = all_watches + q;
      ticks += 1 + kissat_cache_lines (SIZE_WATCHES (*q_watches),
                                       sizeof (watch));

when q = 2147483647.

(haven't gotten around to create a minimal reproducible example.)

I've no idea what causes this, so I decide to just install standalone kissat and write a plugin that uses write to dimacs (.cnf) format and invoke the executable with subprocess.run.

@alexeyignatiev
Copy link
Collaborator

Thanks for checking, @user202729 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants