Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pysolvers not properly rebuilt when compilation flags changed #193

Closed
user202729 opened this issue Feb 7, 2025 · 0 comments
Closed

Pysolvers not properly rebuilt when compilation flags changed #193

user202729 opened this issue Feb 7, 2025 · 0 comments

Comments

@user202729
Copy link

Remark: the disadvantage is minimal and can be easily fixed with git clean -fxd, I don't expect this to be solved. And so far I have only seen it on the version of latest master with #181 merged, but it looks reasonable to expect the same to happen with other engines.


To reproduce:

  • start with a clean checkout

  • run pip install . --verbose

  • see the line building 'pysolvers' extension being printed out

  • modify the source code by

     diff --git a/solvers/patches/kissat4.patch b/solvers/patches/kissat4.patch
     index 53ccde2..4a739c6 100644
     --- a/solvers/patches/kissat4.patch
     +++ b/solvers/patches/kissat4.patch
     @@ -3928,7 +3928,7 @@ diff -Naur solvers/kissat4/Makefile solvers/kissat4/Makefile
      +
      +# main parameters
      +CXX      := c++
     -+CXXFLAGS := -std=c++11 -fPIC -Wall -Wno-deprecated -fno-strict-aliasing -Wno-changes-meaning
     ++CXXFLAGS := -std=c++11 -fPIC -Wall -Wno-deprecated -fno-strict-aliasing -Wno-changes-meaning -g3
      +CXXOPT   := -O3 -DNDEBUG -DLOGGING
      +CXXDEBUG := -O0 -g3
      +CXXPROF  := -O3 -g3 -fno-inline -fno-omit-frame-pointer -pg -DNDEBUG
  • run pip install . --verbose

  • now the line building 'pysolvers' extension is not printed out — showing the pysolvers .o and .so file
    not being correctly regenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant