Schutz inequality measures #75
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
=======================================
+ Coverage 96.3% 96.7% +0.4%
=======================================
Files 5 7 +2
Lines 433 491 +58
=======================================
+ Hits 417 475 +58
Misses 16 16
|
for more information, see https://pre-commit.ci
|
(note to self: continue to always check for 'pending' status on reviews moving forward) |
|
(also, i think you started the schutz branch from your atkinson branch, so this commit includes both additions). Can probably close #74 |
Co-authored-by: James Gaboardi <[email protected]>
Co-authored-by: James Gaboardi <[email protected]>
|
Seems like we need to increase the timeout on the testing workflow. There Mac and Windows aren't finish within 30 minutes, but they almost are... |
|
Probably bumping to 35 minutes should do the trick. |
|
kinda taking awile for not a ton of functionality. Have we turned on parallel tests here yet? |
|
The timeout comes only on Mac and Win and only in this PR. Given ubuntu runs in under a minute, I smell some issue related to non-linux runtime of something in this PR. If that is the case, bumping the timeout is probably not the optimal solution but we should figure out what is causing so massive performance difference. |
|
My suspicion has to do with some tests I added for the plots. Trying to get the blessing of the codecov gods, I added some tests to cover, well everything. When I run them locally, separate windows actually get generated locally now (just noticed this this morning). |
| assert pytest.approx(schutz_obj.coefficient, 0.1) == expected_coefficient | ||
|
|
||
|
|
||
| def test_schutz_plot_runs_without_errors(example_dataframe): |
There was a problem hiding this comment.
Check if this is causing the timeout on mac and windows ci.
|
for more information, see https://pre-commit.ci
| @@ -0,0 +1,197 @@ | |||
| import matplotlib.pyplot as plt | |||
There was a problem hiding this comment.
Inequality does not depend on matplotlib as of now, so this either needs to be imported in a function or we need to add matplotlib to dependencies. This is now failing momepy CI which is tested against dev inequality.
No description provided.