Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add matplotlib as a dependency #79

Closed
jGaboardi opened this issue Sep 2, 2024 · 1 comment · Fixed by #80
Closed

add matplotlib as a dependency #79

jGaboardi opened this issue Sep 2, 2024 · 1 comment · Fixed by #80
Assignees
@sjsrey @jGaboardi @martinfleis
Labels
maint

Comments

@jGaboardi
Copy link
Member

xref #75 (review)

Since we are using matplotib in schutz and pen, perhaps it makes sense to just go ahead and make it a requirement?
@jGaboardi jGaboardi added the maint label Sep 2, 2024
@martinfleis
Copy link
Member

Given splot will be dismantled, it is quite likely that we may want lib and esda depend on it as well, so it is probably fine. Just needs to be done explicitly.

@jGaboardi jGaboardi mentioned this issue Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjsrey sjsrey

@jGaboardi jGaboardi

@martinfleis martinfleis

Labels
maint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add matplotlib as a requirement jGaboardi/inequality
3 participants
@sjsrey @jGaboardi @martinfleis