sourcebuild: add fixme regarding version

pypdfium2-team · Nov 10, 2023 · 4f2d3cc · 4f2d3cc
1 parent 923e258
commit 4f2d3cc
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/setupsrc/pypdfium2_setup/build_pdfium.py b/setupsrc/pypdfium2_setup/build_pdfium.py
@@ -128,9 +128,11 @@ def _dl_unbundler():
 
 def identify_pdfium():
     # if not updated, we'll always be dirty because of the patches, so not much point checking it
+    # FIXME `git describe --all` stopped working correctly??
     desc = run_cmd(["git", "describe", "--all"], cwd=PDFiumDir, capture=True)
     desc = desc.rsplit("/", maxsplit=1)[-1]
     v_short, *id_parts = desc.split("-")
+    v_short = int(v_short)
     assert len(id_parts) < 2
 
     # FIXME some duplication with base::parse_given_tag()