Skip to content

Commit

Permalink
sourcebuild: build config corrections
Browse files Browse the repository at this point in the history
First, note the previous change not only commented out, but accidentally
swapped the value from False to True.

Correct this and reland use_custom_libcxx = false by disabling partition
alloc entirely in the syslibs build.
Move use_allocator_shim = false to the default build (i.e. always set)
to match pdfium-binaries.
  • Loading branch information
mara004 committed Nov 9, 2023
1 parent a7e5aa3 commit 923e258
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions setupsrc/pypdfium2_setup/build_pdfium.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
]


# run `gn args out/Default/ --list` for flag docs
# run `gn args out/Default/ --list` for build config docs

DefaultConfig = {
"is_debug": False,
Expand All @@ -40,6 +40,7 @@
"pdf_enable_v8": False,
"pdf_enable_xfa": False,
"pdf_use_skia": False,
"use_allocator_shim": False,
}

SyslibsConfig = {
Expand All @@ -51,13 +52,13 @@
"use_system_zlib": True,
"use_system_libtiff": True,
"clang_use_chrome_plugins": False,
"use_allocator_shim": False,
"pdf_use_partition_alloc": False,
"use_sysroot": False,
}


# if sys.platform.startswith("linux"):
# SyslibsConfig["use_custom_libcxx"] = True
if sys.platform.startswith("linux"):
SyslibsConfig["use_custom_libcxx"] = False
if sys.platform.startswith("darwin"):
DefaultConfig["mac_deployment_target"] = "10.13.0"
SyslibsConfig["use_system_xcode"] = True
Expand Down

0 comments on commit 923e258

Please sign in to comment.