Skip to content

Change names of documentation files #6647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2022
Merged

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented May 19, 2022

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Follow-up to #6628 (comment) and closes #6646.

@coveralls
Copy link

coveralls commented May 19, 2022

Pull Request Test Coverage Report for Build 2350183740

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.353%

Totals Coverage Status
Change from base Build 2346865518: 0.0%
Covered Lines: 16066
Relevant Lines: 16849

πŸ’› - Coveralls

@DanielNoord
Copy link
Collaborator Author

DanielNoord commented May 19, 2022

@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas Failure is due to block-disables. See the comment above.

Rather than trying to fiddle around with redirects on three different levels, let's just keep the old names. Sphinx takes the top header as file name anyway so that's not an issue. And using messages_introduction instead of index isn't really an issue imo. Both indicate that it is the top-level page of the messages section.

See also the issue, which is my rationale for fixing this rather than keeping as is.

@Pierre-Sassoulas
Copy link
Member

Make sense. Regarding the block disable, should we merge #6642 ? I don't see why the check fails (it's very hard to see where there was an error in the output).

@DanielNoord
Copy link
Collaborator Author

You can search for broken. That makes the error message linkcheck uses for broken links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This page does not exist yet.
3 participants