Skip to content

[doc] Fix the link to block disable in useless-import-alias related #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Apparently the redirect in #6628 is not perfect.

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time linkcheck helped us πŸ˜„

@coveralls
Copy link

coveralls commented May 18, 2022

Pull Request Test Coverage Report for Build 2351077468

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.353%

Totals Coverage Status
Change from base Build 2350520206: 0.0%
Covered Lines: 16066
Relevant Lines: 16849

πŸ’› - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the fix-link-in-documentation branch 2 times, most recently from e5f483f to de7de90 Compare May 19, 2022 08:31
@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 Blocked by a particular issue label May 19, 2022
@Pierre-Sassoulas Pierre-Sassoulas changed the title [doc] Fix the link to block disablein useless-import-alias related [doc] Fix the link to block disable in useless-import-alias related May 19, 2022
@Pierre-Sassoulas
Copy link
Member Author

Can we revert #6647, if sphinx-reredirect works with relative path ? :)

@DanielNoord
Copy link
Collaborator

Can we revert #6647, if sphinx-reredirect works with relative path ? :)

πŸ˜…

We might. Let me retry!

@Pierre-Sassoulas
Copy link
Member Author

Sorry I pushed something that cut the pipeline, I'll let you work on this issue, let me know if I can help. I'm testing with #6642 (comment) right now, but we might need to add real CI tests later.

@DanielNoord
Copy link
Collaborator

Sorry I pushed something that cut the pipeline, I'll let you work on this issue, let me know if I can help. I'm testing with #6642 (comment) right now, but we might need to add real CI tests later.

Yeah no worries. I missed that your comment which kind of rescoped this from the block_disable to all broken redirects.

@DanielNoord
Copy link
Collaborator

Okay, so the block disable link works with this iteration. Shall we use #6651 to finish the redirects once and for all and keep this PR for the block disable fix?

@DanielNoord DanielNoord removed the Blocked 🚧 Blocked by a particular issue label May 19, 2022
@Pierre-Sassoulas Pierre-Sassoulas merged commit 2a25397 into pylint-dev:main May 19, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the fix-link-in-documentation branch May 19, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants