-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[doc] Fix the link to block disable in useless-import-alias related #6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Fix the link to block disable in useless-import-alias related #6642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First time linkcheck
helped us π
Pull Request Test Coverage Report for Build 2351077468
π - Coveralls |
e5f483f
to
de7de90
Compare
Link that need to work before we merge (will update): |
Can we revert #6647, if sphinx-reredirect works with relative path ? :) |
π We might. Let me retry! |
Sorry I pushed something that cut the pipeline, I'll let you work on this issue, let me know if I can help. I'm testing with #6642 (comment) right now, but we might need to add real CI tests later. |
Yeah no worries. I missed that your comment which kind of rescoped this from the |
Okay, so the block disable link works with this iteration. Shall we use #6651 to finish the redirects once and for all and keep this PR for the block disable fix? |
Type of Changes
Description
Apparently the redirect in #6628 is not perfect.