-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Reorganize the documentation table of content #6589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize the documentation table of content #6589
Conversation
1665994
to
fd8c320
Compare
Pull Request Test Coverage Report for Build 2373165816
π - Coveralls |
360f722
to
046c65f
Compare
4560518
to
99af2a6
Compare
99af2a6
to
351b6f9
Compare
I haven't looked at anything yet, but saw some of the renames. Just my two cents: I do like how we're restructuring the documentation, but I would suggest something like: Tutorial
User guide/Using pylint
Development
Additional commands
Changelogs
Contact I think those headers clearly separate the different functions the documentation serves and points users to their desired place quickly and efficiently. |
351b6f9
to
0007a7c
Compare
all-options | ||
features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All options and features are really close in content, should we only keep features and rename it pylint's options ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything in features
that isn't covered by messages
and all-options
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha I suppose features is the one we should suppress, but I liked its appearance better than all-options.
460be7d
to
c6dd902
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked at the actual code just want to finalise the structure first. Some comments:
- Shall we move
pylint features
andoptional pylint checkers
fromconfiguration
to either the top-level or a newcheckers
sub-category? They don't really fit in configuration, especially after we remove the stuff about options. - Let's also expand the developer guide like you did with the user guide.
Contributing
can be a top-level link for example. - Let's move around
Support
andChangelog
. The changelog is probably something people want to look at more often than our contact page.
This is starting to look really good π
391ba12
to
7509ed5
Compare
Just did 2) 3). I think as we did 2) we need to regroup some subsection so the table of content do not take too much space vertically.
I don't know if pylint_features can be moved to somewhere it makes more sense because there is too much in it with too little sections and it's hard to make sense of it without reading everything. In general option/configuration doc is a mess. I think we need to add more link and explanation in the generated documentation and rely on it more, or entirely. For example we could add links to option affecting a messages in the messages documentation and link to messages being affected by an option in the option documentation. Or we could be moving the RST documentation to the code so the generated doc integrate the old rst doc automatically. Then we can remove the old manually typed rst and focus on making the generated doc better. I think this is something that can wait for 2.15 though. There's some thing I'm thinking about doing before 2.15:
|
Okay, just a proposal based on the current subsections:
Same number of subsections as now, but with a better separation of messages, configuration and checkers.
Two sections removed compared to current version with more sub-levels. I think we should set max-level to 3 here so that they can be seen when you expand them. The rest stays the same. |
7509ed5
to
ae2ee0b
Compare
Applied the new toc with the exceptions of the |
7b76098
to
624c7e4
Compare
User, developper, contributor, maintainer.
624c7e4
to
e2dbc93
Compare
@Pierre-Sassoulas One more question before I (finally) review this. Have you considered keeping the files in their current place but only changing the |
We could have done that but that would make future maintenance harder (toctree un clear) in order to not have to do redirection now and I just (laboriousely π) did the redirections so I think there's no benefits anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final move I would make.
As for content, some of the new index.rst
files are a little empty. But I think that's fine for now. Let's worry about the structure first!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While here, may as well fix some language!
Co-authored-by: Jacob Walls <[email protected]>
Type of Changes
Description
Create a user guide part and a developper guide part to distinguish the two. First step for #5728. If we want to do that properly (old links working) we need to do quite a lot of redirection.
Link that need to still works after this:
https://pylint--6589.org.readthedocs.build/en/6589/user_guide/index.html
https://pylint--6589.org.readthedocs.build/en/6589/development_guide/index.html
https://pylint--6589.org.readthedocs.build/en/6589/development_guide/contribute.html
https://pylint--6589.org.readthedocs.build/en/6589/how_tos/custom_checkers.html
https://pylint--6589.org.readthedocs.build/en/6589/how_tos/index.html
https://pylint--6589.org.readthedocs.build/en/6589/how_tos/plugins.html
https://pylint--6589.org.readthedocs.build/en/6589/how_tos/transform_plugins.html
https://pylint--6589.org.readthedocs.build/en/6589/technical_reference/checkers.html
https://pylint--6589.org.readthedocs.build/en/6589/technical_reference/index.html
https://pylint--6589.org.readthedocs.build/en/6589/technical_reference/startup.html
https://pylint--6589.org.readthedocs.build/en/6589/technical_reference/features.html
https://pylint--6589.org.readthedocs.build/en/6589/user_guide/options.html
https://pylint--6589.org.readthedocs.build/en/6589/user_guide/ide_integration/ide-integration.html
https://pylint--6589.org.readthedocs.build/en/6589/development_guide/tests/index.html
https://pylint--6589.org.readthedocs.build/en/6589/development_guide/tests/install.html
https://pylint--6589.org.readthedocs.build/en/6589/development_guide/tests/launching_test.html
https://pylint--6589.org.readthedocs.build/en/6589/development_guide/tests/writting_test.html
https://pylint--6589.org.readthedocs.build/en/6589/development_guide/contributor_guide.html
https://pylint--6589.org.readthedocs.build/en/6589/user_guide/ide_integration/flymake-emacs.html
https://pylint--6589.org.readthedocs.build/en/6589/user_guide/ide_integration/textmate.html
https://pylint--6589.org.readthedocs.build/en/6589/user_guide/pre-commit-integration.html
https://pylint--6589.org.readthedocs.build/en/6589/user_guide/options.html
https://pylint--6589.org.readthedocs.build/en/6589/user_guide/output.html
https://pylint--6589.org.readthedocs.build/en/6589/user_guide/run.html