Skip to content

[Doc] Create a contact section and cleanup the introduction #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ”¨ Refactoring
βœ“ πŸ“œ Docs

Description

Small reviewable extract from #6589

@@ -1,14 +0,0 @@

Some projects using Pylint
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because it's super outdated and we're not some kind of startup trying to secure funding so it's noise.

@coveralls
Copy link

coveralls commented May 14, 2022

Pull Request Test Coverage Report for Build 2325150764

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.346%

Totals Coverage Status
Change from base Build 2321261148: 0.0%
Covered Lines: 16043
Relevant Lines: 16826

πŸ’› - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas force-pushed the create-a-contact-section branch from 7e2868d to 604d71b Compare May 14, 2022 12:22
@@ -1,58 +0,0 @@
.. -*- coding: utf-8 -*-

==============
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth breaking old links for this? I think we should add a redirect.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've searched a way to do it in the configuration file but I don't think it's possible. Do you happen to know how to do it ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I have never done this, but it should be possible. At least with a Sphinx extension.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it should be possible to do it with readthedoc conf directly but after 60+mn I just took an extension to do it.

Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comments about the actual content. Only the redirections left.

with very few false positives), mypy_, pyright_ or pyre_ (typing checks), bandit_ (security
oriented checks), black_ and isort_ (auto-formatting), autoflake_ (automated removal of
unused import or variable), pyupgrade_ (automated upgrade to newer python syntax) and
pydocstringformatter_ (automated pep257).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ˜„

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's your last chance to give this tool a cool name, Daniel.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship has sailed I think πŸ˜„ And I really don't know anything better.


.. _`astroid`: https://github.com/PyCQA/astroid

2.4 What versions of Python is Pylint supporting?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it wouldn't hurt to keep this in the FAQ. As I can easily see people wondering about this and the FAQ would be one the first places I would look for this information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to remove the faq or create two faqs, one for users and one for developer. We might as well document the pylint version vs python interpreter... or maybe pip is handling that and you don't need to know ? Do you mind if we do that in the following merge request ?

@@ -43,8 +46,16 @@
"pylint_options",
"sphinx.ext.autosectionlabel",
"sphinx.ext.intersphinx",
"sphinx_reredirects",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project doesn't seem very well maintained. After the initial release of 0.0.1 a lot of open issue were never dealt with.

Are we sure want to use it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah 0.0.1 does not inspire confidence. But the current version is working well enough, and it's just a dict of simple redirect so worst case scenario we can still switch later if required.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 52138e9 into pylint-dev:main May 15, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the create-a-contact-section branch May 15, 2022 12:20
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants