Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor fixes #834

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Various minor fixes #834

merged 1 commit into from
Feb 1, 2025

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Feb 1, 2025

  • Use the _build_graph method for building the agent graph in the Agent class, rather than a direct call to the agent graph function
  • Fix the fact that we were closing the run_span right away when graph runs were auto-instrumented.
  • Tweak the implementation of the Graph.run loop so that we don't modify the value of start_node, which is a bit confusing, and allows us to remove a branch from the conditional. The remaining code is closer to what I'd expect a user to make use of (though I still want to simplify further, as demonstrated in Add GraphRun object to make use of next more ergonomic #833)

@dmontagu dmontagu enabled auto-merge (squash) February 1, 2025 01:03
@dmontagu dmontagu merged commit 344cc6a into main Feb 1, 2025
11 checks passed
@dmontagu dmontagu deleted the dmontagu/minor-fixes branch February 1, 2025 01:05
@github-actions github-actions bot temporarily deployed to deploy-preview February 1, 2025 01:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant