Add GraphRun object to make use of next more ergonomic
#833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
changed the title
next more ergonomic
Merged
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
6ce755e to
571d805
Compare
dmontagu
force-pushed
the
dmontagu/stream-tool-calls
branch
from
1443b49 to
c4e9180
Compare
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
571d805 to
04fc74c
Compare
dmontagu
commented
Feb 1, 2025
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
39a6009 to
2621543
Compare
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
873fe35 to
e4d384a
Compare
samuelcolvin
reviewed
Feb 6, 2025
There was a problem hiding this comment.
overall looks good, but obviously needs more work, and will conflict with #824.
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
aa74a7c to
bc681bc
Compare
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
17409cc to
0b93143
Compare
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
There was a problem hiding this comment.
should this be public since the nodes you get from iterating are now kind of public?
There was a problem hiding this comment.
I think it's enough to leave the module private and re-export the node classes, but I'm also okay to make the module public.
There was a problem hiding this comment.
I think I've done the re-export thing now, and it works for me in pycharm, but it might be worth double-checking on your end
dmontagu
commented
Feb 18, 2025
dmontagu
commented
Feb 18, 2025
Docs Preview
|
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
6460a73 to
241f179
Compare
dmontagu
force-pushed
the
dmontagu/graph-run-object
branch
from
241f179 to
c7ab89f
Compare
dmontagu
commented
Feb 20, 2025
Comment on lines
+42
to
+47
| # Re-exporting like this improves auto-import behavior in PyCharm | ||
| capture_run_messages = _agent_graph.capture_run_messages | ||
| EndStrategy = _agent_graph.EndStrategy | ||
| HandleResponseNode = _agent_graph.HandleResponseNode | ||
| ModelRequestNode = _agent_graph.ModelRequestNode | ||
| UserPromptNode = _agent_graph.UserPromptNode |
There was a problem hiding this comment.
@samuelcolvin let me know if you think there's a better way to do this. (I tried other things I could think of and this worked best.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of trying to reduce the amount of stuff happening in
Graph.runthat wasn't just innext.It's now in a pretty good state, it does the thing we discussed of implementing
__await__,__anext__, andasync def nextto provide a way to async iterate over the result of callingagent.run, hijack the execution withnext, or justawaitit to get the output without iteration.