BREAKING CHANGE: Remove state generic from graphs #824
Conversation
|
But doesn't this mean that now nodes have a |
That's kind of the point the "state" of a fsm IS which node it's on. Having two states (the |
samuelcolvin
force-pushed
the
remove-state-generic
branch
from
48e15fc to
6a8ce6c
Compare
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
samuelcolvin
changed the title
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
|
@dmontagu please review. |
uv.lock
Outdated
There was a problem hiding this comment.
Thanks for catching this in this PR 👍
| """The node that was run.""" | ||
| start_ts: datetime = field(default_factory=_utils.now_utc) | ||
| """The timestamp when the node started running.""" | ||
| duration: float | None = None | ||
| """The duration of the node run in seconds.""" | ||
| kind: Literal['node'] = 'node' | ||
| """The kind of history step, can be used as a discriminator when deserializing history.""" | ||
| # TODO waiting for https://github.com/pydantic/pydantic/issues/11264, should be an InitVar |
There was a problem hiding this comment.
Btw, PR merged and pc released with this fix, just not yet a major pydantic version :)
dmontagu
force-pushed
the
remove-state-generic
branch
from
cd35bae to
959946a
Compare
|
@samuelcolvin my point was more about how there's now less of a clear distinction between graph state and node state. Like when should a state attribute be put in Maybe it's a dumb idea but what if the distinction between "graph"and "node" state was removed so there's just node-level state attributes? I.e. Each Node only has the state info it either needs directly or to provide to another node |
This is passing except docs which I will update once we've agreed it's a good idea.
this is a step towards storing graph state in a database. My realization was that previously the graph had two things which defined state:
ctx.stateIf we get rid of
ctx.state:The point is, if you want a "state" object has we had before, you just need to pass it between nodes, which was happening under the hood anyway.
I think this makes graphs less complicated and less magic without adding significantly more ceremony or boilerplate.
@dmontagu let's discuss when you're online.