Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Do not use reducer if there is no callback in SignalInstance.resume #278

Merged
merged 3 commits into from
Feb 21, 2024
Merged

perf: Do not use reducer if there is no callback in SignalInstance.resume #278

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8629958
perf: Do not use reducer if there is no callback in `SingalInstance.r…
Czaki Feb 21, 2024
e8bf80e
Merge branch 'main' into remove_reducer_call_on_no_slot
tlambert03 Feb 21, 2024
9ec3f99
Update src/psygnal/_signal.py
Czaki Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/psygnal/_signal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,6 +1127,10 @@ def resume(self, reducer: ReducerFunc | None = None, initial: Any = _NULL) -> No
# EventedModel.update, it may be undefined (as seen in tests)
if not getattr(self, "_args_queue", None):
return
if len(self._slots) == 0:
self._args_queue = []
return

if reducer is not None:
if len(inspect.signature(reducer).parameters) == 1:
args = cast("ReducerOneArg", reducer)(self._args_queue)
Expand Down
Loading