Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Do not use reducer if there is no callback in SignalInstance.resume #278

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Feb 21, 2024

This is followup to #277

Remove the whole reducing operation if there is no callback.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab5dfc5) 100.00% compared to head (9ec3f99) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #278   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         1926      1929    +3     
=========================================
+ Hits          1926      1929    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 21, 2024

CodSpeed Performance Report

Merging #278 will not alter performance

Comparing Czaki:remove_reducer_call_on_no_slot (9ec3f99) with main (ab5dfc5)

Summary

✅ 66 untouched benchmarks

@Czaki Czaki marked this pull request as ready for review February 21, 2024 15:38
@Czaki
Copy link
Contributor Author

Czaki commented Feb 21, 2024

Should I add test for it? (some mocking of reducer)

@tlambert03
Copy link
Member

works for me!

Co-authored-by: Talley Lambert <[email protected]>
@tlambert03
Copy link
Member

Should I add test for it? (some mocking of reducer)

normally i'd say don't bother, but since we've got 100% coverage here, might as well keep it :)

@tlambert03
Copy link
Member

actually... it's fine. the logic is so simple, and it does get covered by tests already. will merge. thanks!

@tlambert03 tlambert03 merged commit 9cdce45 into pyapp-kit:main Feb 21, 2024
54 checks passed
@Czaki Czaki deleted the remove_reducer_call_on_no_slot branch February 23, 2024 15:16
@tlambert03 tlambert03 changed the title perf: Do not use reducer if there is no callback in SingalInstance.resume perf: Do not use reducer if there is no callback in SignalInstance.resume Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants