-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Do not use reducer if there is no callback in SignalInstance.resume
#278
perf: Do not use reducer if there is no callback in SignalInstance.resume
#278
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 1926 1929 +3
=========================================
+ Hits 1926 1929 +3 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #278 will not alter performanceComparing Summary
|
Should I add test for it? (some mocking of reducer) |
works for me! |
Co-authored-by: Talley Lambert <[email protected]>
normally i'd say don't bother, but since we've got 100% coverage here, might as well keep it :) |
actually... it's fine. the logic is so simple, and it does get covered by tests already. will merge. thanks! |
SingalInstance.resume
SignalInstance.resume
This is followup to #277
Remove the whole reducing operation if there is no callback.