Refactor: Extract rule window UI into a module #2462
Conversation
MattHag
force-pushed
the
extract_rule_ui
branch
3 times, most recently
from
06ee777
to
10274a3
Compare
|
Further splits up the diversion rules module and updates the interfaces as, necessary. @pfps Please review this |
MattHag
force-pushed
the
extract_rule_ui
branch
8 times, most recently
from
b379175
to
239fb01
Compare
|
There are some conflicts that need to be addressed. |
|
Yeah, that's still WIP currently. Needs a little more work until it's ready. I've accidentally overridden the first commits, which were ready for merging. |
|
Why are there seven new files? |
MattHag
force-pushed
the
extract_rule_ui
branch
3 times, most recently
from
f54e201
to
22e88f1
Compare
|
That's because it's a refactoring, which once more moves 600 lines of code from the diversion rules module into smaller modules, which do one thing and already became quite close to unit testable. This leads to a clearer structure and maintenance easier. |
MattHag
force-pushed
the
extract_rule_ui
branch
2 times, most recently
from
efd8f61
to
d297aca
Compare
Extract the rule window related code in order to simplify and shrink the diversion rule module.
Removes global clipboard variable.
Replace global rules variable by testable class.
Handle permanent storage of rules with a class. Remove the need for global variable and introduce testable code.
Discard and reopening rules, didn't show the previous rules.
- Checks builtin rules - Checks loading from YAML file
|
This change further splits up the huge diversion rules module and creates a hierarchy. The aim are self-contained modules, which are testable. Avoid hard dependencies on e.g. GTK to enable lightweight unit tests of UI related code. Also aim for a common code base to share business logic between CLI and UI. The interface is only an add-on, which connects to the provided interface.
|
|
Without changes like that, nobody will ever be able to work on the UI without owning a huge amount of supported Logitech devices. |
Extract the rule window related code in order to simplify and shrink the diversion rule module.
Related #2390