Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to emit MX Master gesture events while moving rather than at end of move #2513

Open
Elektrobomb opened this issue Jun 2, 2024 · 10 comments

Comments

@Elektrobomb
Copy link

Problem

  • In Logi options for Windows, the default behaviour for some gestures (e.g. media controls) is to continuously vary the modified value while the Gesture button is held down.
    • For example, when changing volume I can hold the gesture button and move up and down until I am happy with the volume and then release the button to stop modifying the value
  • In contrast, Solaar only seems to support discrete gestures.
    • For example: if I gesture up, I get one step of volume modification regardless of distance travelled my the mouse and the volume is only set on release of the gesture button.

Solution?

  • I think the easiest solution to this issue would be to add a checkbox to the "Gestures" dropdown to enable continuous gestures (or something named similarly)
  • This would change the behaviour of the gesture class to emit gesture events continuously when they are received rather than only at the end of the move
  • I'm going to see if I can have a crack at implementing the above but any help / guidance would be appreciated
@pfps
Copy link
Collaborator

pfps commented Jun 2, 2024

One issue with this is the added computational cost of running rules for each mouse movement. An implementation more like sliding DPI might be better.

@rdhar
Copy link

rdhar commented Jun 4, 2024

Thanks @pfps, was just thinking that opening up sliding DPI for @Elektrobomb's volume use-case (or even zoom in/out) would be the perfect match. For example:

  • Back button + Gesture Up = Volume Up
  • Back button + Gesture Down = Volume Down

EDIT:
From the screenshot below, I had to amend "Back Button" "Mouse Gesture" before it worked(!)

image

@pfps
Copy link
Collaborator

pfps commented Jun 4, 2024

You have to change the Diversion for Back Button to be Mouse Gestures.

@rdhar
Copy link

rdhar commented Jun 4, 2024

Thank you! I'm just about to follow the example rule file's thumb wheel configuration to emular behaviour similar to this on an MX Master 3S.

Specifically, Thumb Wheel UP = Ctrl + Tab, and Thumb Wheel DOWN = Ctrl + Shift + Tab.

What's the best way to go about this?

@pfps
Copy link
Collaborator

pfps commented Jun 4, 2024

The problem with this is that you might get a lot of tabs so you may want to use the special thumb wheel parameter. See the rules documentation for more information.

@Allowexe
Copy link

I'll want the same possibility too

@MattHag
Copy link
Contributor

MattHag commented Aug 14, 2024

The problem with this is that you might get a lot of tabs so you may want to use the special thumb wheel parameter. See the rules documentation for more information.

Somehow the thumb wheel parameters and all the rule configuration descriptions don't show up in 1.1.13 Ubuntu install. It might be related to parsing errors of the rules.yaml, which might be related to the refactoring of the rule loading part.

@pfps
Copy link
Collaborator

pfps commented Aug 14, 2024

Please provide solaar -ddd log and screenshot.

@MattHag
Copy link
Contributor

MattHag commented Sep 15, 2024

Specifically, Thumb Wheel UP = Ctrl + Tab, and Thumb Wheel DOWN = Ctrl + Shift + Tab.

What's the best way to go about this?

This should be all you need, when diversion is active for the scroll wheel. Just configure it with the keys you want.

%YAML 1.3
---
- Rule:
  - Test: [thumb_wheel_up, 10]
  - KeyPress:
    - [Control_L, Page_Down]
    - click
...
---
- Rule:
  - Test: [thumb_wheel_down, 10]
  - KeyPress:
    - [Control_L, Page_Up]
    - click
...

@MattHag
Copy link
Contributor

MattHag commented Sep 15, 2024

The problem with this is that you might get a lot of tabs so you may want to use the special thumb wheel parameter. See the rules documentation for more information.

Somehow the thumb wheel parameters and all the rule configuration descriptions don't show up in 1.1.13 Ubuntu install. It might be related to parsing errors of the rules.yaml, which might be related to the refactoring of the rule loading part.

#2462 Okay, that's not even merged, but could fix the issues and test the loading of rules.

BTW: I'll try to provide a log, if rule loading issues persist on that notebook with Solaar 1.1.13 and tested it with config files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants