Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-560) Consider short and long SHAs #561

Closed
wants to merge 1 commit into from
Closed

(GH-560) Consider short and long SHAs #561

wants to merge 1 commit into from
+2 −1

Commits on Aug 1, 2022

  1. (GH-560) Consider short and long SHAs 

    As pointed out in #560, the check for SHA equality only
currently works for long shas which are 40 characters.

If a short SHA with :revision rev-parse HEAD returns a long SHA
therefore rendering the equality check false.

e.g

"cb1eb6" != "cb1eb6bb33eb6889818f5b02aa593b4ff2f8ca33"

This commit updates the args so that rev-parse will always return a SHA
that is the same length as the value provided with the :revision
parameter.

This will cause the check to be true and exit get_revision early as it would
do when both values are 40 characters.
    @chelnak
    chelnak committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    0013975 View commit details
    Browse the repository at this point in the history