(GH-560) Consider short and long SHAs #561
Conversation
As pointed out in #560, the check for SHA equality only currently works for long shas which are 40 characters. If a short SHA with :revision rev-parse HEAD returns a long SHA therefore rendering the equality check false. e.g "cb1eb6" != "cb1eb6bb33eb6889818f5b02aa593b4ff2f8ca33" This commit updates the args so that rev-parse will always return a SHA that is the same length as the value provided with the :revision parameter. This will cause the check to be true and exit get_revision early as it would do when both values are 40 characters.
|
Hello! 👋 This pull request has been open for a while and has had no recent activity. We've labelled it with If you are waiting on a response from us we will try and address your comments on a future Community Day. Alternatively, if it is no longer relevant to you please close the PR with a comment. Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error. |
|
Could this be reopened, and the checks rerun. The logs have expired, and I'm curious to see what the failures were |
|
@giggsey looks like there was a set of 10 failures occurring across all tested OSs |
|
Thanks @LukasAud My quick scanning looks like the change not handling when revision isn't used. I guess wrapping the new change in an if statement, and keeping the old logic in other scenarios would handle that |
|
We have investigated and confirmed this issue. However, we cannot currently allocate any resources to completing this PR. This work is currently in our backlog but we cannot give an estimate of when we will be able to get onto it. For now, we will be closing this PR to avoid keeping it stale and deterring other users from attempting to contribute a solution. |
As pointed out in #560, the check for SHA equality only
currently works for long shas which are 40 characters.
If a short SHA with :revision rev-parse HEAD returns a long SHA
therefore rendering the equality check false.
e.g
"cb1eb6" != "cb1eb6bb33eb6889818f5b02aa593b4ff2f8ca33"
This commit updates the args so that rev-parse will always return a SHA
that is the same length as the value provided with the :revision
parameter.
This will cause the check to be true and exit get_revision early as it would
do when both values are 40 characters.