Remove gotestfmt #1069
Merged
Remove gotestfmt #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blampe
approved these changes
Sep 5, 2024
flostadler
approved these changes
Sep 5, 2024
guineveresaenger
approved these changes
Sep 5, 2024
|
@t0yv0, @guineveresaenger Late to the party but we've had the same issues in azure-native and I had good initial results with tparse instead. Here's a draft PR; you can look at the test results. It's essentially just regular |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Take 2 on removing gotestfmt. Since extension workflows still use it, retain the installation stanza, but not actually use in tests. pulumi/pulumi-azure-native#3404 is promising but to be evaluated later I think? Previously: #1069 #1071
thomas11
added a commit
to pulumi/pulumi-azure-native
that referenced
this pull request
Sep 27, 2024
Following ci-mgmt where it [was already removed](pulumi/ci-mgmt#1069).
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engineers noticing gotestfmt reporting test output in a confusing way, such as mis-attributing logs from one test to another or not reporting logs if a panic is encountered. This change removes this utility, switching to default Go test output. It also removes the
-vflag so that the test failure output is minimally scoped to the failing tests and is easier to find. Defaults for the win.