Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many providers depend on gotestfmt in custom tests #1070

Closed
iwahbe opened this issue Sep 6, 2024 · 1 comment
Closed

Many providers depend on gotestfmt in custom tests #1070

iwahbe opened this issue Sep 6, 2024 · 1 comment
Assignees
Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed

Comments

@iwahbe
Copy link
Member

iwahbe commented Sep 6, 2024

Many providers invoke gotestfmt in preTest provider test blocks. They relied on gotestfmt being installed. Since #1069 uninstalled gotestfmt, the workflow upgrades are now failing CI.

Example of a provider using gotestfmt in .ci-mgmt.yaml:

actions:
  preTest:
    - name: make upstream
      run: |
        make upstream
    - name: Run provider tests
      run: |
        cd provider && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt

(src)

It looks like this effects about 40 providers. You can see a list of failing workflow upgrades here.

@iwahbe iwahbe added needs-triage Needs attention from the triage team p1 A bug severe enough to be the next item assigned to an engineer labels Sep 6, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 6, 2024
Reverts #1069

I'll redo it without removing GoTestFmt install step to fix:

#1070
@VenelinMartinov VenelinMartinov added kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed and removed needs-triage Needs attention from the triage team labels Sep 9, 2024
@VenelinMartinov
Copy link
Contributor

fixed in #1071

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

3 participants