Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gunicorn worker recycling #573

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Support gunicorn worker recycling #573

merged 2 commits into from
Jan 19, 2024

Conversation

markafarrell
Copy link
Contributor

Currently the memory usage of the multi-process container increases over time the majority contributor is the gunicorn workers for pulpcore-api

The suggested fix for these type of issues seems to be to enable worker recycling.

pulp/pulpcore/issues/2250

The suggested solution of editing gunicorn.conf.py, however, does not work (I think due to how s6-overlay works)

This changes adds some additional environment variables that can be use to configure gunicorn worker recycling for both pulpcore-api and pulpcore-content

Copy link
Member

@mikedep333 mikedep333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much!

@mikedep333
Copy link
Member

@markafarrell Lint is failing.

You need a file CHANGES/576.feature on your commit that says "fixes #576"

@markafarrell
Copy link
Contributor Author

@markafarrell Lint is failing.

You need a file CHANGES/576.feature on your commit that says "fixes #576"

Fixed.... hopefully

@markafarrell
Copy link
Contributor Author

markafarrell commented Jan 18, 2024

CI is failing due to:

 The conflict is caused by:
    The user requested pulpcore 3.45.0.dev0 (from git+https://github.com/pulp/pulpcore.git#egg=pulpcore)
    pulp-ansible 0.22.0.dev0 depends on pulpcore<3.55 and >=3.40.0
    pulp-certguard 1.8.0.dev0 depends on pulpcore<3.45 and >=3.28.0

pulp-certguard's pulpcore version restrictions need to be expanded

pulp/pulp-certguard#352
pulp/pulp-certguard#353

@markafarrell
Copy link
Contributor Author

markafarrell commented Jan 19, 2024

 pulp-oci-images CI / app-images (stable, pulp, pulp-web, pulpcore) (pull_request) Failing after 19m

This also appears to be failing on latest

#579

@mikedep333
Copy link
Member

@markafarrell Yeah, we'll fix both of those 2 issues soon.

Thank you!

@mikedep333 mikedep333 merged commit 1cbe88b into pulp:latest Jan 19, 2024
12 of 15 checks passed
@mdellweg
Copy link
Member

This change is incompatible with (at least) pulpcore 3.34. I'm inclined to revert it.

@mdellweg
Copy link
Member

Nightlies are failing for some days now. We need to revert this and find a better solution.
https://github.com/pulp/pulp_gem/actions/runs/7620480802/job/20755309808#step:10:558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants