-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gunicorn worker recycling #573
Support gunicorn worker recycling #573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you so much!
@markafarrell Lint is failing. You need a file CHANGES/576.feature on your commit that says "fixes #576" |
Fixed.... hopefully |
CI is failing due to:
|
This also appears to be failing on latest |
@markafarrell Yeah, we'll fix both of those 2 issues soon. Thank you! |
This change is incompatible with (at least) pulpcore 3.34. I'm inclined to revert it. |
Nightlies are failing for some days now. We need to revert this and find a better solution. |
Currently the memory usage of the multi-process container increases over time the majority contributor is the gunicorn workers for pulpcore-api
The suggested fix for these type of issues seems to be to enable worker recycling.
pulp/pulpcore/issues/2250
The suggested solution of editing
gunicorn.conf.py
, however, does not work (I think due to how s6-overlay works)This changes adds some additional environment variables that can be use to configure gunicorn worker recycling for both pulpcore-api and pulpcore-content