Revert "Support gunicorn worker recycling" #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a breaking change and is not compatible with all versions of pulpcore. The options introduced here are not guaranteed to exist. And so starting the container fails. [noissue]
mdellweg
force-pushed
the
revert-573-feature/support-gunicorn-worker-recycling
branch
from
6f00023
to
77101db
Compare
|
Sorry @markafarrell , we need to revert this until a new PR is opened up. The problem is that our CI for plugins uses the current Dockerfiles (pulp_ci_centos) to test installing older versions of pulpcore as well. The entrypoint changed from So we need to only add these arguments if the new binaries are in use. |
mikedep333
deleted the
revert-573-feature/support-gunicorn-worker-recycling
branch
|
I do believe the thing is that these specific options were added even later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #573