Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI flow. #20

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Add CI flow. #20

merged 6 commits into from
Mar 11, 2024

Conversation

yvantor
Copy link
Collaborator

@yvantor yvantor commented Feb 17, 2024

No description provided.

@yvantor yvantor self-assigned this Feb 17, 2024
@yvantor yvantor marked this pull request as draft February 17, 2024 11:50
@yvantor yvantor added the enhancement New feature or request label Feb 17, 2024
@yvantor
Copy link
Collaborator Author

yvantor commented Feb 17, 2024 •
edited
Loading

This PR is inteded to add a CI flow to:

  • Check code stile (lint) of RTL and SW code.
  • Test functionality.

@yvantor yvantor force-pushed the yt/ci-1 branch 5 times, most recently from 38c0357 to 9cc0c00 Compare February 22, 2024 21:59
@yvantor yvantor force-pushed the yt/ci-1 branch 5 times, most recently from 6f972ba to 3134b28 Compare February 25, 2024 10:44
@yvantor yvantor force-pushed the yt/ci-1 branch 11 times, most recently from 2213135 to 0f276da Compare February 25, 2024 21:05
@yvantor yvantor force-pushed the yt/ci-1 branch 7 times, most recently from 5cbe718 to ea06f15 Compare February 26, 2024 15:50
@yvantor yvantor force-pushed the yt/ci-1 branch 2 times, most recently from 00a210a to 60c70a2 Compare February 27, 2024 23:13
@yvantor yvantor marked this pull request as ready for review February 27, 2024 23:15
FrancescoConti
FrancescoConti reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@FrancescoConti FrancescoConti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, a few minor comments here and there.

FrancescoConti
FrancescoConti approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@FrancescoConti FrancescoConti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvantor
Copy link
Collaborator Author

yvantor commented Mar 11, 2024

Merging.

@yvantor yvantor merged commit 84b976d into main Mar 11, 2024
9 checks passed
@yvantor yvantor deleted the yt/ci-1 branch March 11, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescoConti FrancescoConti FrancescoConti approved these changes

Assignees

@yvantor yvantor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvantor @FrancescoConti