Fix problems with GCC optimization and cMake #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
I noticed that GCCs tree-loop-distribute-patterns optimization can lead to infinite loops and stack overflows. This was tested with banshee simulations.
Further, the custom
memcpy
andmemset
implementation insoftware/runtime/string.c
is sometimes swapped out with the GCC built-in function. However, this tends to lead to cause some bytes not to be copied if the number of bytes is at multiple of 4.Finally, when using cMake with GCC, the configuration steps can fail because
install/riscv-gcc/riscv32-unknown-elf/lib/riscv.ld
is missing.Fixed
riscv.ld
required for cMake to install foldermemset
andmemcpy
built-in functionsChecklist