Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Remove begin/end from constructors to fix morty ci err #364

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

viv-eth
Copy link

@viv-eth viv-eth commented Jan 20, 2025

This PR refactors the AXI module constructors in test/tb_axi_dw_pkg.sv by removing redundant begin...end blocks. The primary objective is to streamline the constructor definitions to account for parser errors occurring in the sv-parser crate used by morty.

  • The removal addresses parsing issues related to super.new(...) calls, ensuring that the sv-parser can accurately interpret method calls without being constrained by unnecessary block delimiters.
  • The begin...end blocks within constructors were redundant, as the constructor's logic doesn't require multiple procedural statements that necessitate such blocks.

The functional behavior and RTL characteristics of the AXI module remain unchanged. The constructor continues to initialize and configure module parameters as intended.

@thommythomaso thommythomaso self-assigned this Jan 21, 2025
@thommythomaso thommythomaso added the bug Something isn't working label Jan 21, 2025
@thommythomaso thommythomaso merged commit b3735d1 into pulp-platform:master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants