Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPEN: Minor CI and Readme Improvements #8

Merged
merged 7 commits into from
Nov 3, 2024

Conversation

Victor-Jung
Copy link
Member

@Victor-Jung Victor-Jung commented Oct 24, 2024

In this PR, we:

  • Improves the README, explaining how to get started with Deeploy using the Docker container. In the future I will add more content such as 'How to install dependencies manually', 'How to add tests to the CI', and 'How to add new dependencies'.
  • Update the link of the docker container used to run the CI; previously, it was pointing at my fork.
  • BUGFIX: Add a step to retry on timeout for the tests of large networks on Siracusa.
  • Schedule a CI run every 6 days at 2am to keep the cache fresh.

Copy link
Collaborator

@Xeratec Xeratec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Do you want to add a section explaining the CI in the Readme in this PR or another one? As this PR is not a critical change I suggest adding it here. Otherwise feel free to merge.

@Victor-Jung Victor-Jung changed the title OPEN: Fix CI Docker Link OPEN: CI and Readme Improvements Oct 28, 2024
@Victor-Jung Victor-Jung changed the title OPEN: CI and Readme Improvements OPEN: Minor CI and Readme Improvements Oct 28, 2024
@Victor-Jung
Copy link
Member Author

@Xeratec I improved the README and added a read Getting Started section for beginners. More detailed tutorials on the CI and CD flow will come later if that's fine for you.

Copy link
Collaborator

@Xeratec Xeratec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge.
One question, tough. Do we have more insight into why some test on Siracusa time out sometimes? If it is a problem in our codebase, please open an issue.

@Victor-Jung Victor-Jung merged commit b404150 into pulp-platform:devel Nov 3, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants