OPEN: GitHub-based CI/CD Flow #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Victor-Jung
force-pushed
the
pr/github-action-ci
branch
from
45f4ae8
to
63977b0
Compare
Minor: - Fix banshee.patch - Fix python dependenciy
Victor-Jung
force-pushed
the
pr/github-action-ci
branch
from
42f65b5
to
394124d
Compare
|
LGTM, thanks for the effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
This PR adds a GitHub-based Continuous Integration and Deployment to Deeploy. With this flow, we propagate a Docker container carrying Deeploy's dependencies. This allows new users to simply pull the Docker container and run Deeploy out-of-the-box. Moreover, the CI tests are run into this container.
On a personal GitHub account, one has access to 40 concurrent jobs, and the runtime of the CI is 14min. On the organization repo, we have only 20 concurrent jobs, so the runtime is 29min.
Added
CI.ymlworkflow containing the CI tests.BuildDocker.ymlworkflow that builds and pushes to GHCR the docker containing Deeploy's dependencies.Changed
main.ymltoGitLabCI.yml.Fixed
Makefile.onnx-graphsurgeonto0.3.20, using the latest version results in errors for theICCT_ITA_8ONNX graph.banshee.patchby freezing the version ofunicode-widthto0.1.13. Since a few days, the default version is0.1.14, while it was0.1.13earlier. The version0.1.14is working only for Rust version above or equal to1.66.