Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPEN] GVSOC support for the Snitch Cluster platform #23

Merged
merged 7 commits into from
Jan 14, 2025
Merged

[OPEN] GVSOC support for the Snitch Cluster platform #23

merged 7 commits into from
Jan 14, 2025

Conversation

tahaelbayad
Copy link
Contributor

@tahaelbayad tahaelbayad commented Jan 9, 2025 •
edited by lukamac
Loading

This PR introduces GVSOC as a simulator for the Snitch cluster platform.

Added

  • gvsoc in the Makefile and dockerfile
  • cmake flow for gvsoc
  • CI tests regarding Snitch run on GVSOC as well

Changed

  • Added the RTL library to the snitch_cluster build process in the Makefile, required for GVSOC simulation

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. Change the docker image back to ghcr.io/pulp-platform/deeploy:main.
  5. The CHANGELOG.md file has been updated.

lukamac
lukamac reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@lukamac lukamac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Container/Dockerfile Show resolved Hide resolved
DeeployTest/Platforms/Snitch/main.c Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
cmake/simulation.cmake Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
lukamac
lukamac approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@lukamac lukamac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge after you complete all the checks in the PR merge checklist :)

@lukamac lukamac merged commit 3c64bda into pulp-platform:devel Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victor-Jung Victor-Jung Victor-Jung left review comments

@lukamac lukamac lukamac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tahaelbayad @lukamac @Victor-Jung