Fix Generic Softmax Kernel #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xeratec
force-pushed
the
pr/fix_softmax
branch
from
6aa2f23
to
096ce2a
Compare
Xeratec
changed the title
Scheremo
previously requested changes
Oct 9, 2024
Xeratec
commented
Oct 10, 2024
Victor-Jung
approved these changes
Oct 21, 2024
Victor-Jung
force-pushed
the
pr/fix_softmax
branch
from
096ce2a
to
2659a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the softmax kernel for the generic platform. The kernel is now aligned with the well tested implementation of PULPOpen. Furthermore, the
iSoftmaxtest is added to the internal GitLab CI for the generic platform.How to Reproduce