Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for testing lc call slips on staging #738

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add documentation for testing lc call slips on staging #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@
## Staging Mail Catcher
To See mail that has been sent on the staging server you must ssh tunnel into the server

ssh -L 1082:localhost:1080 pulsys@lib-jobs-staging1
Once the tunnel is open you can see the mail that has been sent on staging [here](localhost:8082)
ssh -L 1082:localhost:1080 pulsys@lib-jobs-staging1

Once the tunnel is open you can see the [mail that has been sent on staging here](http://localhost:1082)

## Getting Started

Expand Down
21 changes: 21 additions & 0 deletions docs/lc_call_slips/testing_on_staging.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
### Testing LC Call Slips on staging

One convenient way to try your changes on
production-like data is to run the process on
staging:

1. Deploy main to staging.
1. SSH into one of the staging boxes and run `cd /opt/lib-jobs/current && bundle exec rake lib_jobs:process_newly_cataloged_records`
1. [Open mailcatcher](../../README.md#staging-mail-catcher).
1. Download one of the CSVs that you'd like to compare.
1. Repeat the above steps, but with your branch deployed to staging.
1. Compare the diff between the two CSVs to see
if it is what you expect. Note that the order
of rows may change, and this doesn't indicate
a problem.
1. You may also choose to run `bundle exec rake lib_jobs:create_csv_for_selector_comparison`, which
generates a CSV of all possible records from OCLC,
including ones that are typically filtered out like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually filters out the ones that don't meet the criteria for the generally_relevant? method. I was just saying that it used to be that the generally_relevant? method was where we excluded based on publication location, but now that decision is made in the relevant_to_selector? method.

So, it should exclude juvenile, audiobooks, etc., but will include US / UK / Canada publications.

juvenile materials. You can use this one to make
sure that your CSV in mailcatcher includes all the
expected rows.
Loading