Add documentation for testing lc call slips on staging #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkadel
reviewed
Mar 29, 2024
| a problem. | ||
| 1. You may also choose to run `bundle exec rake lib_jobs:create_csv_for_selector_comparison`, which | ||
| generates a CSV of all possible records from OCLC, | ||
| including ones that are typically filtered out like |
There was a problem hiding this comment.
It actually filters out the ones that don't meet the criteria for the generally_relevant? method. I was just saying that it used to be that the generally_relevant? method was where we excluded based on publication location, but now that decision is made in the relevant_to_selector? method.
So, it should exclude juvenile, audiobooks, etc., but will include US / UK / Canada publications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix the link and formatting in the README's mailcatcher section.