Fix Dockerfile to use locked dependencies #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the dockerfile will copy the package.json and package-lock.json. Additionally npm clean-install instead of install will be called in the root folder. This downloads all dependencies without possibly modifying the lock file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #171
The Dockerfile now copies package.json and package-lock.json too. Instead of installing the dependencies in each sub-project (e.g. frontend and backend) it now uses the workspaces defined in the main package.json to handle this (only one install call). For reproducible builds "clean-install" is now used as this operation never modifies the lock file (in contrast to the regular install command).
The .dockerignore now includes all unnecessary folders that should not be copied to the image.