Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package-lock not used in Dockerfile #171

Closed
Tomtec331 opened this issue Feb 9, 2024 · 0 comments · Fixed by #172
Closed

Package-lock not used in Dockerfile #171

Tomtec331 opened this issue Feb 9, 2024 · 0 comments · Fixed by #172
Assignees
Labels
enhancement New feature or request

Comments

@Tomtec331
Copy link
Collaborator

Currently when creating a docker image with the provided Dockerfile the root package.json and the repo package-lock.json won't be used. This can lead to different versions of dependencies being installed in the container which might break the current code. This is easily fixed by copying the related files and force npm to install the declared dependencies.

@Tomtec331 Tomtec331 added the enhancement New feature or request label Feb 9, 2024
@Tomtec331 Tomtec331 self-assigned this Feb 9, 2024
@Tomtec331 Tomtec331 linked a pull request Feb 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant