Skip to content

compaction: introduce compaction_options parameter (WIP)

Sign in for the full log view
GitHub Actions / Clang-Tidy failed Feb 18, 2025 in 0s

[Clang-Tidy] 50 warnings

[Clang-Tidy] 50 warnings

Annotations

Check warning on line 34 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 36 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 41 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

performance-unnecessary-value-param

parameter 'file_names' is passed by value and only copied once; consider moving it to avoid unnecessary copies 

Check warning on line 48 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 49 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 55 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

readability-redundant-member-init

initializer for member 'file_names_' is redundant 

Check warning on line 62 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 63 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 65 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 70 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

performance-unnecessary-value-param

parameter 'file_names' is passed by value and only copied once; consider moving it to avoid unnecessary copies 

Check warning on line 78 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 79 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 81 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 87 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

performance-unnecessary-value-param

parameter 'file_names' is passed by value and only copied once; consider moving it to avoid unnecessary copies 

Check warning on line 93 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard

function 'get_from_dir' should be marked [[nodiscard]] 

Check warning on line 96 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard

function 'get_to_dir' should be marked [[nodiscard]] 

Check warning on line 99 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard

function 'get_num_worker' should be marked [[nodiscard]] 

Check warning on line 102 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard

function 'get_file_names' should be marked [[nodiscard]] 

Check warning on line 105 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard

function 'has_file_set' should be marked [[nodiscard]] 

Check warning on line 108 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard

function 'is_gc_enabled' should be marked [[nodiscard]] 

Check warning on line 112 in src/limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-use-nodiscard

function 'get_gc_snapshot' should be marked [[nodiscard]] 

Check warning on line 86 in src/limestone/dblog_scan.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 98 in src/limestone/dblog_scan.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move 

Check warning on line 98 in src/limestone/dblog_scan.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

performance-unnecessary-value-param

the parameter 'options' is copied for each invocation but only used as a const reference; consider making it a const reference 

Check warning on line 34 in src/./limestone/compaction_options.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy

modernize-pass-by-value

pass by value and use std::move