Skip to content
Limestone-CI

compaction: introduce compaction_options parameter (WIP) #950

Sign in to view logs

compaction: introduce compaction_options parameter (WIP)

compaction: introduce compaction_options parameter (WIP) #950

Triggered via push February 18, 2025 07:21
@umeganeumegane
pushed 73ea9e7
wip/blob
Status Failure
Total duration 1m 21s
Artifacts –

ci-build.yml

on: push
Analysis
1m 11s
Analysis
Matrix: Build
Fit to window
Zoom out
Zoom in

Annotations

1 error and 50 warnings
Analysis
modernize-pass-by-value: src/limestone/compaction_options.h#L34
pass by value and use std::move
modernize-pass-by-value: src/limestone/compaction_options.h#L36
pass by value and use std::move
performance-unnecessary-value-param: src/limestone/compaction_options.h#L41
parameter 'file_names' is passed by value and only copied once; consider moving it to avoid unnecessary copies
modernize-pass-by-value: src/limestone/compaction_options.h#L48
pass by value and use std::move
modernize-pass-by-value: src/limestone/compaction_options.h#L49
pass by value and use std::move
readability-redundant-member-init: src/limestone/compaction_options.h#L55
initializer for member 'file_names_' is redundant
modernize-pass-by-value: src/limestone/compaction_options.h#L62
pass by value and use std::move
modernize-pass-by-value: src/limestone/compaction_options.h#L63
pass by value and use std::move
modernize-pass-by-value: src/limestone/compaction_options.h#L65
pass by value and use std::move
performance-unnecessary-value-param: src/limestone/compaction_options.h#L70
parameter 'file_names' is passed by value and only copied once; consider moving it to avoid unnecessary copies
modernize-pass-by-value: src/limestone/compaction_options.h#L78
pass by value and use std::move
modernize-pass-by-value: src/limestone/compaction_options.h#L79
pass by value and use std::move
modernize-pass-by-value: src/limestone/compaction_options.h#L81
pass by value and use std::move
performance-unnecessary-value-param: src/limestone/compaction_options.h#L87
parameter 'file_names' is passed by value and only copied once; consider moving it to avoid unnecessary copies
modernize-use-nodiscard: src/limestone/compaction_options.h#L93
function 'get_from_dir' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L96
function 'get_to_dir' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L99
function 'get_num_worker' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L102
function 'get_file_names' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L105
function 'has_file_set' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L108
function 'is_gc_enabled' should be marked [[nodiscard]]
modernize-use-nodiscard: src/limestone/compaction_options.h#L112
function 'get_gc_snapshot' should be marked [[nodiscard]]
modernize-pass-by-value: src/limestone/dblog_scan.h#L86
pass by value and use std::move
modernize-pass-by-value: src/limestone/dblog_scan.h#L98
pass by value and use std::move
performance-unnecessary-value-param: src/limestone/dblog_scan.h#L98
the parameter 'options' is copied for each invocation but only used as a const reference; consider making it a const reference
modernize-pass-by-value: src/./limestone/compaction_options.h#L34
pass by value and use std::move
modernize-pass-by-value: src/./limestone/compaction_options.h#L36
pass by value and use std::move
performance-unnecessary-value-param: src/./limestone/compaction_options.h#L41
parameter 'file_names' is passed by value and only copied once; consider moving it to avoid unnecessary copies
modernize-pass-by-value: src/./limestone/compaction_options.h#L48
pass by value and use std::move
modernize-pass-by-value: src/./limestone/compaction_options.h#L49
pass by value and use std::move
readability-redundant-member-init: src/./limestone/compaction_options.h#L55
initializer for member 'file_names_' is redundant
modernize-pass-by-value: src/./limestone/compaction_options.h#L62
pass by value and use std::move
modernize-pass-by-value: src/./limestone/compaction_options.h#L63
pass by value and use std::move
modernize-pass-by-value: src/./limestone/compaction_options.h#L65
pass by value and use std::move
performance-unnecessary-value-param: src/./limestone/compaction_options.h#L70
parameter 'file_names' is passed by value and only copied once; consider moving it to avoid unnecessary copies
modernize-pass-by-value: src/./limestone/compaction_options.h#L78
pass by value and use std::move
modernize-pass-by-value: src/./limestone/compaction_options.h#L79
pass by value and use std::move
modernize-pass-by-value: src/./limestone/compaction_options.h#L81
pass by value and use std::move
performance-unnecessary-value-param: src/./limestone/compaction_options.h#L87
parameter 'file_names' is passed by value and only copied once; consider moving it to avoid unnecessary copies
modernize-use-nodiscard: src/./limestone/compaction_options.h#L93
function 'get_from_dir' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L96
function 'get_to_dir' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L99
function 'get_num_worker' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L102
function 'get_file_names' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L105
function 'has_file_set' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L108
function 'is_gc_enabled' should be marked [[nodiscard]]
modernize-use-nodiscard: src/./limestone/compaction_options.h#L112
function 'get_gc_snapshot' should be marked [[nodiscard]]
modernize-pass-by-value: src/./limestone/dblog_scan.h#L86
pass by value and use std::move
modernize-pass-by-value: src/./limestone/dblog_scan.h#L98
pass by value and use std::move
performance-unnecessary-value-param: src/./limestone/dblog_scan.h#L98
the parameter 'options' is copied for each invocation but only used as a const reference; consider making it a const reference
performance-unnecessary-value-param: src/limestone/datastore_snapshot.cpp#L303
the parameter 'options' is copied for each invocation but only used as a const reference; consider making it a const reference
performance-unnecessary-copy-initialization: src/limestone/datastore_snapshot.cpp#L307
the variable 'to_dir' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference