Proposal for TC_CC_2.1 #37328
Closed
Proposal for TC_CC_2.1 #37328
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
PR #37328: Size comparison from 3044eeb to 36b94e4 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37328: Size comparison from f7226c1 to a835fd4 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
juandediosg
reviewed
Feb 12, 2025
|
Changes approved |
juandediosg
approved these changes
Feb 14, 2025
cecille
reviewed
Feb 24, 2025
src/python_testing/TC_CC_2_1.py
Outdated
| self.step(24) | ||
| numberofprimaries_value = await self._verify_attribute("NumberOfPrimaries", self.UINT16, max_len=6) | ||
|
|
||
| # verify for numberofprimaries section |
There was a problem hiding this comment.
The current test plan here is very confusing because it was written to match to the YAML style of tests, which don't support looping. But you can just do a for loop here.
for i in range(1, num_primaries):
verifiy primary i x, y, intensity
for i in range(num_primaries + 1, 6):
verify primaries i x, y, intensity don't exist
jtrejoespinoza-grid
force-pushed
the
TC-CC-2_1
branch
from
e484e93 to
cf45d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Removed pics
Verified attributes using
attribute_guardProposal for Test case for Color Control 2.2 ( TC_CC_2.1)
The following test evaluates the attributes to the conformance.
How to to run:
Run all clusters.
./out/linux-x64-all-clusters/chip-all-clusters-appRun the test case:
python3 src/python_testing/TC_CC_2_1.py --commissioning-method on-network --qr-code MT:-24J0AFN00KA0648G00 --PICS src/app/tests/suites/certification/ci-pics-valuesAll attributes must be present.
There is a conversation right now about the attribute
NumberOfPrimarieswhere the value should not be 0. Currently the change is not implemented. Until the change is implemented this test case will need to be updated.https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/9103