Proposal for TC_CC_2.1 #37911
Open
Proposal for TC_CC_2.1 #37911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sues with previous PR which had some conflicts with submodules. Attribute range rechecks.
|
PR #37911: Size comparison from 7d7d638 to 8b2135b Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jtrejoespinoza-grid
changed the title
…th the default value of 0x009A to allow test TC-CC-2.1
|
PR #37911: Size comparison from 7d7d638 to 95ea072 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…reds. Updated to use LIGHTING_APP_NO_UNIQUE_ID instead of ALL_CLUSTERS_APP
|
PR #37911: Size comparison from 7d7d638 to 3d04c2f Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…ith range in lower limit with ColorTempPhysicalMinMireds at endpoint 1
|
PR #37911: Size comparison from 7d7d638 to b2fc6e2 Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37911: Size comparison from 59c205c to 91a1512 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Mar 12, 2025
|
|
||
| @async_test_body | ||
| async def test_TC_CC_2_1(self): | ||
| self.UINT8 = "uint8" |
There was a problem hiding this comment.
Can you please use an enum rather than doing string compares?
| @@ -9006,7 +9006,7 @@ endpoint 1 { | |||
| ram attribute colorCapabilities default = 0x1F; | |||
| ram attribute colorTempPhysicalMinMireds default = 0x009A; | |||
| ram attribute colorTempPhysicalMaxMireds default = 0x01C6; | |||
| ram attribute coupleColorTempToLevelMinMireds; | |||
| ram attribute coupleColorTempToLevelMinMireds default = 0x009A; | |||
There was a problem hiding this comment.
Would you mind checking with Leo Rozendaal to make sure he's ok with this setting as a default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Proposal for Test case for Color Control 2.1 ( TC_CC_2.1)
The following test evaluates the attributes to the conformance.
How to to run:
Run all clusters.
./out/linux-x64-all-clusters/chip-all-clusters-app
Run the test case: python3 src/python_testing/TC_CC_2_1.py --commissioning-method on-network --qr-code MT:-24J0AFN00KA0648G00 --PICS src/app/tests/suites/certification/ci-pics-values
There is a conversation right now about the attribute NumberOfPrimaries where the value should not be 0. Currently the change is not implemented. Until the change is implemented this test case will need to be updated.
CHIP-Specifications/connectedhomeip-spec#9103
##Fixes
project-chip/matter-test-scripts#392
This PR is raised to replace a previous one, which had some commit issues related with the submodules
Previous PR.
#37328