Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing createPermissionIntegrationRouter call #82

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

kurtaking
Copy link
Contributor

@kurtaking kurtaking commented Oct 26, 2023

Making these changes based on the recommendation from Backstage maintainer.

Code was taken 1:1 from the linked pull request.

We (the permission framework maintainers) updated the correct usage of createPermissionIntegrationRouter, but the docs remained outdated. As part of fixing the docs (backstage/backstage#17388) we're making PRs to help fix the issue in community plugins as well.

Checklist:

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

@kurtaking kurtaking self-assigned this Oct 26, 2023
@kurtaking kurtaking requested a review from a team as a code owner October 26, 2023 02:08
@kurtaking kurtaking force-pushed the Joonpark13/permission-integration-router-fix branch from fc3b577 to 782fa60 Compare October 26, 2023 02:08
@kurtaking kurtaking merged commit 43e6b6a into main Oct 26, 2023
3 checks passed
@kurtaking kurtaking deleted the Joonpark13/permission-integration-router-fix branch October 26, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant